Help forums for JCrawler
amackie
Member
My generated sitemap has empty loc tags in the middle of the document and some page links are missing from the links that are displayed. Otherwise it works fine - the links before and after the blank section are good.
The blanks look like this:
<url>
<loc></loc>
<lastmod>2009-02-17T10:15:50Z</lastmod>
<priority>0.5</priority>
<changefreq>daily</changefreq>
</url>
Any ideas? (And thanks for the great component.)
mohanarun
Member
Hi same problem here - other URLs have loc some urls not having loc but during generation it generates these curl errors and I have curl installed and properly working till now
Curl error on url http://www.nimltdengineering.com/smoking-shelters/free-standing-smoking-shelter-1x25m.html: couldn\'t connect to host
Curl error on url http://www.nimltdengineering.com/smoking-shelters/free-standing-smoking-shelter-2x25m.html: couldn\'t connect to host
Curl error on url http://www.nimltdengineering.com/smoking-shelters/free-standing-smoking-shelter-3x25m.html: couldn\'t connect to host
Curl error on url http://www.nimltdengineering.com/smoking-shelters/free-standing-smoking-shelter-4x25m.html: couldn\'t connect to host
Curl error on url http://www.nimltdengineering.com/smoking-shelters/free-standing-smoking-shelter-9-x-25m.html: couldn\'t connect to host
Curl error on url http://www.nimltdengineering.com/smoking-shelters/premium-smoking-shelter-1x25m.html: couldn\'t connect to host
Curl error on url http://www.nimltdengineering.com/smoking-shelters/premium-smoking-shelter-2x25m.html: couldn\'t connect to host
Curl error on url http://www.nimltdengineering.com/smoking-shelters/premium-smoking-shelter-3x25m.html: couldn\'t connect to host
Curl error on url http://www.nimltdengineering.com/smoking-shelters/premium-smoking-shelter-4x25m.html: couldn\'t connect to host
BHorst
Member
No errors on generation, but the same empty loc\'s...
<url>
<loc></loc>
<lastmod>2009-02-18T10:53:18Z</lastmod>
<priority>0.5</priority>
<changefreq>daily</changefreq>
</url>
Very good component!! Thanks a lot!
BHorst
Member
I changed the File /administrator/components/com_jcrawler/admin.jcrawler.php, to have no longer empty locs:
Find in line 423: \"foreach ($urls as $loc){\"
Delete the line with \"i++;\"
Add \"if (strlen(trim($loc[\'url\'])) > 0){ i++;\" after \"$loc[\'url\']=htmlspecialchars($loc[\'url\']);\"
Add \"}\" after \"</url>\";\"
When you\'re finished it should look like this:
foreach ($urls as $loc){
/* urf-8 encoding */
//$loc=htmlentities($loc,ENT_QUOTES,\'UTF-8\');
//$loc=htmlspecialchars($loc,ENT_QUOTES,\'UTF-8\',false);
$loc[\'url\']=htmlspecialchars($loc[\'url\']);
if (strlen(trim($loc[\'url\'])) > 0){ $i++;
$modified_at = date(\'Y-m-d\\Th:i:s\\Z\');
$xml_string .= \"
<url>
<loc>\".$loc[\'url\'].\"</loc>
<lastmod>$modified_at</lastmod>
<priority>\".$priority.\"</priority>
<changefreq>\".$freq.\"</changefreq>
</url>\";
}
}
Now no more empty loc\'s
lumo
Member
Well done BHorst, this fixed my blank loc problem,
Thanks
Jalby
Member
This definitely cleared up my missing locs, the sitemap validates and I saved 300 MB of error log! Thanks mate. Does this now constitute 1.7 Beta?
patrick
Key Master
thanks, yeah thats a fix!
but i found the true problem, that leads to the empty loc\'s and fixed it already!
greets Patrick
jerren
Member
What\'s the official problem/fix Patrik? I\'m seeing the same problem.
FSGDAG
Member
I\'ve made the changes above, but now I\'m getting an error when trying to run jcrawler.
Here is my code:
_____________
foreach ($urls as $loc){
/* urf-8 encoding */
//$loc=htmlentities($loc,ENT_QUOTES,\\\'UTF-8\\\');
//$loc=htmlspecialchars($loc,ENT_QUOTES,\\\'UTF-8\\\',false);
$loc[\\\'url\\\']=htmlspecialchars($loc[\\\'url\\\']);
if (strlen(trim($loc[\\\'url\\\'])) > 0){ $i++;
$modified_at = date(\\\'Y-m-d\\\\Th:i:s\\\\Z\\\');
$xml_string .= \\\"
<url>
<loc>\\\".$loc[\\\'url\\\'].\\\"</loc>
<lastmod>$modified_at</lastmod>
<priority>\\\".$priority.\\\"</priority>
<changefreq>\\\".$freq.\\\"</changefreq>
</url>\\\";
}
}
_________________
And here is the error messages I\'m getting when trying to run jcrawler:
Warning: Unexpected character in input: \'\\\' (ASCII=92) state=1 in /home/xxxx/public_html/administrator/components/com_jcrawler/admin.jcrawler.php on line 428
Parse error: syntax error, unexpected T_STRING, expecting \']\' in /home/xxxx/public_html/administrator/components/com_jcrawler/admin.jcrawler.php on line 527
FSGDAG
Member
Forget my post above... :) I found what I was doing wrong and fixed it :) No more blank lines :)
Rogier
Member
Tried to use that fix, but:
Warning: Unexpected character in input: \'\\\' (ASCII=92) state=1 in /home/********/domains/********/public_html/administrator/components/com_jcrawler/admin.jcrawler.php on line 429
Parse error: syntax error, unexpected T_STRING, expecting \']\' in /home/********/domains/********/public_html/administrator/components/com_jcrawler/admin.jcrawler.php on line 527
Can somebody tell what goes wrong on line 429 and 527?
Rogier
Member
This is the corrected code: (line 423)
foreach ($urls as $loc){
/* urf-8 encoding */
//$loc=htmlentities($loc,ENT_QUOTES,\'UTF-8\');
//$loc=htmlspecialchars($loc,ENT_QUOTES,\'UTF-8\',false);
$loc[\'url\']=htmlspecialchars($loc[\'url\']);
if (strlen(trim($loc[\'url\'])) > 0){ $i++;
$modified_at = date(\'Y-m-d\\Th:i:s\\Z\');
$xml_string .= \"
<url>
<loc>\".$loc[\'url\'].\"</loc>
<lastmod>$modified_at</lastmod>
<priority>\".$priority.\"</priority>
<changefreq>\".$freq.\"</changefreq>
</url>\";
}
}
Rogier
Member
Fixed Component:
http://www.pixelschieber.ch/forum/topic/jcrawler-16b-beta#post-172
You must log in to post.